This repository was archived by the owner on Oct 12, 2022. It is now read-only.
fix issue 11293 (locale enumeration for Windows, OS X, Linux) #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum LC_TIME = 5; | ||
| enum LC_MESSAGES = 6; | ||
| } | ||
| else |
|
Thanks. All that's left is to squash them into a single commit. If you need help with that let me know! |
Add the missing LC_MESSAGES constant for Linux. Fix the enumeration values for Windows, OS X and FreeBSD, which were using Linux's values, incorrectly.
|
AndrejMitrovic: I squashed it into a single commit. I didn't do that earlier because I thought that force pushing (removing commits that you had already seen) would be bad, so I appended new commits. I'll amend / rebase interactive in the future, if that's what's desirable. |
|
Well squashing depends on the pull. But you typically wouldn't want many commits which do trivial things (e.g. "added bracket around if" or something like that, it's not worth a separate commit). |
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2013
fix issue 11293 (locale enumeration for Windows, OS X, Linux)
ghost
merged commit
|
Typically you would also add a link to the bugzilla issue in the github pull request description (I've edited your post to include it). Anyway thanks! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing LC_MESSAGES constant for Linux.
Fix the enumeration values for Windows and OS X, which were using Linux's values, incorrectly.
http://d.puremagic.com/issues/show_bug.cgi?id=11293