Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

yebblies
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Feb 11, 2014

Auto-merge toggled on

@ghost
Copy link

ghost commented Feb 11, 2014

LGTM, and automerging since this has blocked development for git-head users.

@yebblies
Copy link
Contributor Author

Thanks, dlang/dmd#3245 should go green when this is done.

@ghost
Copy link

ghost commented Feb 11, 2014

Random Msys failure on win32 it seems.

ghost pushed a commit that referenced this pull request Feb 11, 2014
Allow calling .get on a const AA
@ghost ghost merged commit c7e4a05 into dlang:master Feb 11, 2014
@MartinNowak
Copy link
Member

Thanks

@CyberShadow
Copy link
Member

This pull request introduced a regression:
https://d.puremagic.com/issues/show_bug.cgi?id=12221

@WalterBright
Copy link
Member

So how about we revert this P.R. ?

@yebblies
Copy link
Contributor Author

So how about we revert this P.R. ?

I think that would trade one regression for another.

@WalterBright
Copy link
Member

Revert this PR: #727

I think that would trade one regression for another.

This PR doesn't reference a bugzilla entry, and this is blocking releasing 2.065.

@yebblies
Copy link
Contributor Author

This PR doesn't reference a bugzilla entry

It doesn't, but it was a regression fix.

and this is blocking releasing 2.065.

No, it isn't. Try it. None of the new AA stuff went in the 2.065 branch.

@WalterBright
Copy link
Member

Why does https://d.puremagic.com/issues/show_bug.cgi?id=12221 say 2.065 git head? If it doesn't apply, the bugzilla issue should be updated to reflect that.

In any case, I added a test case dlang/dmd#3331 from the bug report.

@yebblies
Copy link
Contributor Author

Because we haven't changed the version file, so master still thinks it's 2.065.

@WalterBright
Copy link
Member

The bugzilla issue subject should be edited to remove the reference to 2.065, since it isn't in 2.065.

@WalterBright
Copy link
Member

This PR also lacks a test case.

@yebblies
Copy link
Contributor Author

The test cases for this pull were in #3245

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants