[REG2.066a] Issue 12220 - hash.get() does not accept proper parameters

[9rnsr]

https://d.puremagic.com/issues/show_bug.cgi?id=12220

Required compiler enhancement: dlang/dmd#3353

[yebblies]

Because this is a template, can you get rid of inout completely? Or, does defaultValue need to be inout too?

[9rnsr]

Using inout will reduce the number of instantiations of get function template. And yes, we should also need to be defaultValue inout.

Updated.

[yebblies]

Doesn't work with ctfe. Compiler bug?

[9rnsr]

Gaaa, test/runnable/testaa3.d is broken by a new CTFE bug. I'll see it tomorrow.

[9rnsr]

@yebblies Yes, it's definitely a compiler bug and it's unrelated to AA implementations.

The error message in testaa3.d is:

test\runnable\testaa3.d(198): Error: reinterpreting cast from immutable(int[int])* to const(int[int])* is not supported in CTFE
test\runnable\testaa3.d(198):        called from here: get(cast(const(int[int])*)aa, 1, delegate inout(int)() => 2)
test\runnable\testaa3.d(293):        called from here: testPointerImmutable()
test\runnable\testaa3.d(293):        while evaluating: static assert(testPointerImmutable())

But the conversion from immutable(int[int])* to const(int[int])* is not a reinterpret cast.

[9rnsr]

OK, I have found the cause.

https://d.puremagic.com/issues/show_bug.cgi?id=12296
dlang/dmd#3355

[9rnsr]

Ready to merge.

[yebblies]

Auto-merge toggled on

[9rnsr]

Thanks!

[CyberShadow]

This pull request introduced a regression:
https://d.puremagic.com/issues/show_bug.cgi?id=12316