Issue 3882: Remove pure qualifier from assumeSafeAppend and _d_arrayshrinkfit

[nordlow]

No description provided.

[monarchdodra]

to inhibit warnings

Not just that, for correctness :)

If the function is strongly pure, then the compiler can strip it out completely !

[monarchdodra]

Auto-merge toggled on

[dnadlinger]

Auto-merge toggled off

[dnadlinger]

Wait a second: If the function is indeed pure, why wouldn't it also be inferred as such, making this a no-op change? (Feel free to enable auto-merging again if I'm missing something.)

[nordlow]

Oops, _d_arrayshrinkfit should be unpured aswell, right?

Otherwise the compiler can optimize away its call and assumeSafeAppend will have no side-effect GC-wise.

@andralex, @monarchdodra or @schveiguy, what do you say?

[monarchdodra]

Wait a second: If the function is indeed pure , why wouldn't it also be inferred as such

It's a forward declaration: There's no inference here.

[nordlow]

ping

[monarchdodra]

Oops, _d_arrayshrinkfit should be unpured aswell, right?

It's a forward declaration: There's no inference here.

Oops. Yes, of course. _d_arrayshrinkfit should not be marked as pure. He's the real culprit. Good catch @klickverbot .

[nordlow]

Ready to roll?

[monarchdodra]

Squash?

[dnadlinger]

Yes, please squash the changes into one commit (e.g. using git rebase -i), as the history is otherwise confusing to follow (the first commit doesn't actually do much in terms of language semantics).

[nordlow]

Done! :)

[monarchdodra]

Auto-merge toggled on

[nordlow]

Thanks.