This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix wrong comparison of uint[]/int[] due to invalid subtraction. #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fit for inclusion in V.2.066? I'd like similar druntime/Phobos functions to be tested with a QuickCheck-like tool shipped with the standard D distributions: |
quickfur
changed the title
|
@zaicheir good catch, the subtraction was OK in terms of sign, but wrong because it can overflow the return value and return the wrong result. |
|
@zaicheir Oops, you're right, it should be 13073, not 13014 |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Jul 12, 2014
Fix wrong comparison of uint[]/int[] due to invalid subtraction.
tramker
pushed a commit
to tramker/druntime
that referenced
this pull request
Jul 12, 2014
Fix wrong comparison of uint[]/int[] due to invalid subtraction. Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.dlang.org/show_bug.cgi?id=13073