This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 12958 - core.checkedint.mulu is broken. #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the (uint, uint) case using ulong arithmetic and the (ulong, ulong) case using trial division. See Bugzilla for an ulong implementation by David Bregman that does not require a division. As the functions are expected to be implemented as compiler intrinsics to make use of architecture-specific primitives anyway, the simpler version has been chosen to reduce the potential for bugs, even though it is slower.
|
Do the unit tests cover the 'broken' cases? |
|
BTW, when doing pull requests, please include a link to the bugzilla issue, and on the bugzilla issue please include a link to the PR. I have added them for this PR. |
|
Yeah, sorry, I was creating this from the command line (the description is the commit message) and forgot to add the links. There is currently only one new test each, |
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Jul 14, 2014
Fix issue 12958 - core.checkedint.mulu is broken.
9rnsr
pushed a commit
to 9rnsr/druntime
that referenced
this pull request
Jul 14, 2014
Fix issue 12958 - core.checkedint.mulu is broken.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the (uint, uint) case using ulong arithmetic
and the (ulong, ulong) case using trial division. See Bugzilla
for an ulong implementation by David Bregman that does not
require a division. As the functions are expected to be
implemented as compiler intrinsics to make use of
architecture-specific primitives anyway, the simpler version
has been chosen to reduce the potential for bugs, even though
it is slower.