Make _aaRehash @trusted

[nordlow]

According to discussion at http://forum.dlang.org/thread/vrbnnwvelxzsgokjhklj@forum.dlang.org#post-unbpaxaovijsbsgqrcgl:40forum.dlang.org.

[quickfur]

LGTM.

At first I was concerned about keyti.getHash being @system, but it appears that _aaRehash does not call it because the hash value is already stored in the AA node, so it seems reasonable to mark it as @trusted.

[nordlow]

That's also the conclusion of the linked discussion.

[MartinNowak]

because the hash value is already stored in the AA node

True, though I'm not sure if that is a reasonable requirement for any AA implementation.

[quickfur]

Good point. A future AA implementation may implement rehash differently that requires re-evaluating the hash function.

Seems like the ultimate solution is to use template functions in a library AA implementation so that the compiler can infer attributes according to key type. Unfortunately that still seems a ways off.

[MartinNowak]

Seems like the ultimate solution is to use template functions in a library AA implementation so that the compiler can infer attributes according to key type. Unfortunately that still seems a ways off.

Right, and I wouldn't want to commit on something that later breaks code, given the fact that it shouldn't be necessary to call rehash at all.