This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Issue 13410: Improve AA performance by caching index of first-used bucket #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quickfur
changed the title
quickfur
force-pushed
the
issue13410
branch
from
9513606 to
b781545
Compare
|
Updated with latest patch from bugzilla. |
|
I don't think this makes a good addition for the reasons mentioned in Issue 13410 – Performance problem with associative array byKey/byValue. |
|
Should we close this PR then? |
|
I have an idea for fixing this so it doesn't impact performance of existing operations. |
|
See new pull that does not affect aa.remove: #979 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.dlang.org/show_bug.cgi?id=13410
This PR was done on behalf of Ketmar Dark (the original patch was obtained from the above ticket).