Fixes issue 9299 - std.algorithm.minPos of const(int)[] #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6125,7 +6126,7 @@ minCount(alias pred = "a < b", Range)(Range range) | |||
| ++occurrences; | |||
| } | |||
| } | |||
| return tuple(p, occurrences); | |||
| return typeof(return)(v, occurrences); | |||
There was a problem hiding this comment.
This was changed, because if ElementType!Range is immutable(T[]), then this will actually instantiate a Tuple!(immutable(T)[]), which is different from a Tuple!(immutable(T[])) == Tuple!(ElementType!Range).
alexrp
added a commit
that referenced
this pull request
Jan 14, 2013
Fixes issue 9299 - std.algorithm.minPos of const(int)[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minPos didn't work with immutable elements anymore. Fixed and unittested.
Also: re-enforced constraints. Changed
p(implies pointer) for 'v' (implies value).Note that minCount remains broken. It is z bit harder to fix because minCount accepts simple input ranges (no save). The fix is more involved.