Skip to content

Conversation

jacob-carlborg
Copy link
Contributor

These tests were previously commented out because of a bug
the regular expression module. Now when we have a new regular
expression module we can enable these tests.

This also fixed a bug in the internally used "substr" function.

These tests were previously commented out because of a bug
the regular expression module. Now when we have a new regular
expression module we can enable these tests.

This also fixed a bug in the internally used "substr" function.
@braddr
Copy link
Member

braddr commented Mar 23, 2013

The std.json parser is barfing on the json returned from github for this pull request: https://api.github.com/repos/D-Programming-Language/phobos/commits/f6e27e6f79a0831d4d5bb08300e722b40a4f23fd

I haven't dug into it, but I bet it's lines 1101 and 1102 of std.net.isemail.d.

Consequently, it won't be getting tested unless the problem gets fixed.

@jacob-carlborg
Copy link
Contributor Author

Hmm, so the test suite is using std.json somehow to run the tests? According to http://jsonlint.com/ the JSON is valid so seems to be a bug in std.json. I'll see if there's something I can do about it.

@jacob-carlborg
Copy link
Contributor Author

Create a pull request for std.json #1219.

This is just to make it a bit clearer what's going on.
@braddr
Copy link
Member

braddr commented Mar 23, 2013

The test suite, not at all (well, other than in unittests for the std.json module I assume). The tester infrastructure, yes. It necessarily interacts with github which uses json as it's encoding for data interchange.

@jacob-carlborg
Copy link
Contributor Author

Cool the test suite is working again for this pull.

andralex added a commit that referenced this pull request Mar 24, 2013
Enable a bunch of tests for std.net.isemail.
@andralex andralex merged commit 93c4052 into dlang:master Mar 24, 2013
@jacob-carlborg jacob-carlborg deleted the isemail_unittests branch March 24, 2013 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants