fix issue 9979 - regex back-looper bug #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good, thanks for following through with this pull. |
|
|
||
| String opSlice(size_t start, size_t end){ return _origin[end..start]; } | ||
| //index of at End position | ||
| @property size_t lastIndex(){ return 0; } | ||
| } | ||
| @property auto loopBack(){ return BackLooper(this); } | ||
| auto loopBack(size_t index){ return BackLooper(this, index); } | ||
| } | ||
|
|
||
| // Test stream against simple UTF-string stream abstraction (w/o normalization and such) |
There was a problem hiding this comment.
This is a remenant of the original project to add stream based regex support that never took off and bitrotten in the meantime.
Since we're using git to great extent there is no need to keep this junk around anymore - just delete it please in an additional commit.
(you as well missed default arguments in here as if to underline my point)
|
Just address one nit and we should be ready to go. |
|
Cool, thanks. UPDATE: A FreeBSD failure is a usual and totaly unrelated guest. @alexrp @AndrejMitrovic |
andralex
added a commit
that referenced
this pull request
May 26, 2013
fix issue 9979 - regex back-looper bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this code would match an empty string:
auto r = regex(r"A\b", "g");
This fixes the off-by-one error in back-looper and gets it to use the regex position rather than the stream position so there are no problems when the two are out of sync (such as at the end of a stream).