CTFE support for Appender #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes a large chunk of Phobos usable in CTFE. Fixes: 5632 replace() not evaluatable at compile-time anymore This is still not very efficient, for CTFE it's a bit more efficient to just use ~= for appending.
|
Eventually, yes, but it won't work yet because CTFE can't do bit intrinsics yet.There are still some horrific inefficiencies in the CTFE engine anyway which would mean that the speed and memory consumption are dominated by other things (eg, indexing an array isn't yet an O(1) operation in all cases!) |
|
OK, in that case, I think the changes are fine as is. I wonder if it wouldn't be better to just replace the entire implementation with a simple array and use builtin append operations. |
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
Update to DDOX 0.9.19 with multiple declarations per page support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a very sophisticated patch, it just uses the new CTFE capabilities (pointers + heap-allocated structs) and bypasses the low-level stuff in Appender.
It makes a large chunk of Phobos usable in CTFE. For example, it fixes:
5632 replace() not evaluatable at compile-time anymore