Added TypeEnum to std.variant #1298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have a look at this pull: dlang/dmd#1342 |
|
Please follow the D style convention, that means braces on their own line and 4-space indentation. The |
| static if (staticIndexOf!(U, T) == -1) { | ||
| return false; | ||
| } else { | ||
| return _index == staticIndexOf!(U, T); |
There was a problem hiding this comment.
Shouldn't this line suffice, IOW the above static check is unnecessary? I don't see how _index can ever be -1.
|
Closing due to inactivity. |
ghost
closed this
|
Ping one of us if you want this reopened. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new type, TypeEnum which stores just the tag part of an algebraic type.
http://d.puremagic.com/issues/show_bug.cgi?id=10127