Disable SIGPIPE on send()ing to a Socket on OS X. #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires druntime pull request 36 for defining |
|
Thanks. David, could you please also solve the conflict preventing this from automatically merging? Thanks! |
Previously, std.socket code assumed that MSG_NOSIGNAL existed on all platforms, which is not the case – std.c.osx.socket actually has a comment saying »Not defined in OS X, but we'll use them anyway«. This lead to Socket.send() raising SIGPIPE on OS X if the peer had already closed the connection. With this commit, std.socket sets the SO_NOSIGPIPE socket option on systems that support it for the same effect as MSG_NOSIGNAL on Linux. Strictly speaking, removing the NOSIGNAL SocketFlag is a breaking API change, but I do not think there is any code actually using it, as it has always been set implicitly by std.socket anyway.
|
Done – I wonder why GitHub doesn't display something like the Fork Queue for non-comitters… |
andralex
added a commit
that referenced
this pull request
Jul 7, 2011
Disable SIGPIPE on send()ing to a Socket on OS X.
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
fix changed tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
std.socketcode assumed thatMSG_NOSIGNALexisted on all platforms, which is not the case –std.c.osx.socketactually has a comment saying »Not defined in OS X, but we'll use them anyway«. This led toSocket.send()raisingSIGPIPEon OS X if the peer had already closed the connection.With this commit,
std.socketsets theSO_NOSIGPIPEsocket option on systems that support it for the same effect asMSG_NOSIGNALon Linux.Strictly speaking, removing the
NOSIGNALSocketFlagis a breaking API change, but I do not think there is any code actually using it, as it has always been set implicitly anyway.