Fix Issue 10517 - readln(Char)(Char[] buf) accepts non-mutable buffers #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also templatizes a global readln
Just cause a file is nativelly treated as UTF16 (or something), doesn't mean you can iterate wchars.
| @@ -928,7 +930,7 @@ with every line. | |||
| string s = readln(terminator); | |||
| buf.length = 0; | |||
| if (!s.length) return 0; | |||
| foreach (wchar c; s) | |||
| foreach (dchar c; s) | |||
There was a problem hiding this comment.
Yeah, that's probably better.
I ended up doing @9rnsr This made your comment "outdated": I replied to I but did not change the code. |
|
LGTM. |
9rnsr
added a commit
that referenced
this pull request
Jul 3, 2013
Fix Issue 10517 - readln(Char)(Char[] buf) accepts non-mutable buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: http://d.puremagic.com/issues/show_bug.cgi?id=10517
Boards: http://forum.dlang.org/thread/odkkhkgnahhpklvumghv@forum.dlang.org
Note that the old code is considered "accepts-invalid", and is now simply illegal (no deprecation) (per Steven Schveighoffer's recommendation on Boards).
Also templatizes global readln.
Fixes a wchar issue
On topic: Is there a cleaner way to say
isMutableChar!CorisMutableString!S?Semi on topic: We have no "range terminator" signature that returns a string, eg:
I wanted to add it, but we can't due to ambiguity with buffered readln, which is a shame...