Issue 6064: std.array.join is unnecessarily slow for strings #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also went over the other functions in std.array and made them work with immutable arrays where applicable. The unit tests have been appropriately expanded as well.
|
Thanks! I didn't think so much effort was required for this. |
The idea is to make the template constraint match exactly what the user needs to instantiate it rather than seeing the more complex template constraints that the various overloads of join have. Not that the resulting template constraint is altogether short either, but it's now the bare minimum which all join overloads must match rather than including the specifics necessary to distinguish each overload.
|
It didn't take all that long to write it, but it did get a bit complicated with all of the combinations. Unfortunately, it looks like I managed to mix my changes for #143 into here (that and a commit called temp which I just rebased away). So, it looks like that commit needs to be merged in first. But it's not particularly complicated (just a bit tedious), so hopefully it won't take all that long for that to be merged in. You can just ignore the first commit "Made std.array.replace work with immutable arrays again" in this pull request. If you want to comment on those changes, comment on them in pull request #143. |
dsimcha
added a commit
that referenced
this pull request
Jul 16, 2011
Issue 6064: std.array.join is unnecessarily slow for strings
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
rdmd: Don't recompile the program if only current directory changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I optimized std.array.join for arrays (not just strings). It's definitely more complicated now (it doesn't use std.algorithm.joiner anymore when dealing with arrays and ended up with several overloads), but it should be much more efficient for arrays, since it now copies them whole rather than element by element.
http://d.puremagic.com/issues/show_bug.cgi?id=6064