Issue 10874 - conv.to ulong to int enum conversion #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume that is(A : B) means a==b is valid, or that !is(A : B) implies that a==b is invalid. Instead, test for a==b explicitly. More specifically, int and ulong are ==-comparable, even though ulong is not implicitly convertible to int. Thus, one should be able to convert ulong to an int-based enum, but is(A : B) in the signature constraint prohibits this. Testing for a==b explicitly, OTOH, makes this work.
|
LGTM |
|
Just gonna re-wait on the testers, since I just pulled you other |
monarchdodra
added a commit
that referenced
this pull request
Aug 24, 2013
Issue 10874 - conv.to ulong to int enum conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't assume that is(A : B) means a==b is valid, or that !is(A : B)
implies that a==b is invalid. Instead, test for a==b explicitly.
More specifically, int and ulong are ==-comparable, even though ulong is
not implicitly convertible to int. Thus, one should be able to convert
ulong to an int-based enum, but is(A : B) in the signature constraint
prohibits this. Testing for a==b explicitly, OTOH, makes this work.
http://d.puremagic.com/issues/show_bug.cgi?id=10874