Skip to content

Conversation

monarchdodra
Copy link
Collaborator

Just a little series of "trivial" fixups related to my recent emplace fix.

This does not change any existing behavior, or try to fix anything that is broken. It is only mostly cleanup, removing un-needed code, rewrite error messages as cleaner format, as well as reword them a teensy-bit

Simpler to review each pull individually I think.

I'd rather these be fixed now, so I can tackle:

  1. http://d.puremagic.com/issues/show_bug.cgi?id=10973
  2. http://d.puremagic.com/issues/show_bug.cgi?id=10978
    So as to reduce the noise in pulls that actually change things.

@monarchdodra
Copy link
Collaborator Author

Stupid bug.

@monarchdodra
Copy link
Collaborator Author

Unfortunately, I had to remove that last commit, which was hitting some compiler bugs.

All that is left is some very trivial refactoring in emplace(chunk), as well as some error message rewrite.

@monarchdodra monarchdodra reopened this Sep 8, 2013
@monarchdodra
Copy link
Collaborator Author

dnadlinger added a commit that referenced this pull request Oct 8, 2013
@dnadlinger dnadlinger merged commit 353f043 into dlang:master Oct 8, 2013
@denis-sh
Copy link
Contributor

denis-sh commented Oct 8, 2013

Probably I have to present my apologies to @monarchdodra.

Current situation is preposterous. He do what I did a long time ago but was blocked by misunderstanding with Phobos developers. I'd be happy to be able to talk with any of Phobos developers to clarify the situation. You know my e-mail. I always happy to contribute Phobos but it became a nightmare to me that time so I gave up. If anybody can give me about 15 minutes please do it.

@monarchdodra monarchdodra deleted the emplaceFixup branch October 25, 2013 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants