Issue 10875 - Introduce LinkageType enum for safer string comparisons.

[ghost]

http://d.puremagic.com/issues/show_bug.cgi?id=10875

Note that this doesn't break existing code even though the actual type was changed. Well, it /shouldn't/, but if there are any reports of a regression we can turn it back into a string. In that case it will still work with the new LinkageType since these string<=>enum conversions are implicit when the template is called.

[monarchdodra]

LGTM

[monarchdodra]

You need to mark all these with ditto. If you don't, you'll generate an empty paragraph for each entry, rather than a paragraph that holds everything.

EG compare:
http://dlang.org/phobos/std_traits.html#.FunctionAttribute
http://dlang.org/phobos/std_traits.html#.Variadic

[monarchdodra]

I think the template "SetFunctionAttributes" would also need some migrating.

[ghost]

I think the template "SetFunctionAttributes" would also need some migrating.

The tests for this function use functionLinkage internally, it seems to pass the tests. Could you be more specific?

[monarchdodra]

The tests for this function use functionLinkage internally, it seems to pass the tests. Could you be more specific?

It was mostly the line of code

        enum linkages = ["D", "C", "Windows", "Pascal", "C++", "System"];

I was thinking about.

But I'm not sure it's actually related.

[monarchdodra]

Strange, I thought I had left a message about this before, but I can't find it anymore. Maybe someone deleted it? There's no un-delete in git-hub, AFAIK?

Anyways, this mostly looks good to me, and I would have pulled this earlier, but I do have a reservation: It's the:

Cpp = "C++",

What troubles me is that:

void main()
{
    auto a = LinkageType.Cpp;
    assert(a == "C++");
    writeln(a);
}

Prints

Cpp

In particular, I could see this potentially breaking code generating code, that does things such as

mixin(format("extern (%s) foo()", functionLinkage!foo));

Do you think this might be a problem?

[monarchdodra]

https://d.puremagic.com/issues/show_bug.cgi?id=11571

I've been wanting to file this for a while, you just gave me the excuse :)

[ghost]

Good catch. I think we can close the pull and the enhancement, it's almost guaranteed that functionLinkage is mostly used during code-generation, and this pull would break code.

[ghost]

As for comment deletions, for my own comments I use a <del>text</del> section rather than delete them.