Use lstat64() on OS X like on other Posix systems.

[dnadlinger]

Previously, the code was special-cased to use stat64() on OS X for no apparent reason (I searched the logs, but couldn't find anything obvious). This also caused the new symlink() unit tests to fail.

I additionally removed further special casing that excluded certain unit tests from being run on OS X, because I can see no apparent reason for them not to work there as well (and indeed, they all pass on my OS X Lion box).

[jmdavis]

I believe that tests were previously removed precisely because they were breaking and someone (Andrei IIRC) decided that it was easier/better to remove them in the short term. So, if you've fixed them an re-enabled them, that's great.

[jmdavis]

Well, it looks good from what I can see. So, if it passes on your machine, it should be solid. I'll merge it in.

[jmdavis]

And thank you for taking the time to fix this. I don't have access to a Mac, so this is a big help.

[dnadlinger]

Yeah, sure, no problem. I still wonder why the OS X code was special cased not to use lstat64 in the first place, though, as the docs say it existed since 10.5 just like stat64. I had another look at the commit log, and it seems like it was added as a quick build fix by Andrei because you switched the code to use lstat64 on Linux in your d8488a9, but (understandably, if you don't have access to an OS X box) omitted the declaration for OS X.

Well, let's just wait and see if any related issues pop up, I suppose…