Fix for bug# 5731 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm quite certain of these changes, and this pull request will fix the currently broken win32 unit tests for Phobos so that they'll stop failing on the autotester, so if no one has any comments on this within the next 24 hours, I will likely just merge these changes in. |
9rnsr
pushed a commit
that referenced
this pull request
Apr 19, 2011
dnadlinger
pushed a commit
to dnadlinger/phobos
that referenced
this pull request
Sep 2, 2015
Fix Win64 compilation by replacing ilogb with a D version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UTC offsets were being given backwards (+ instead of - and vice versa) in the string functions of SysTime. I fixed that and improved the unit tests related to TimeZone.getTimeZone. It nows tests it on both Posix and Windows.