[ARM] Implement remaining std.math stuff #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2071,7 +2071,7 @@ real frexp(real value, out int exp) @trusted pure nothrow | |||
| else | |||
| { | |||
| exp = (ex - F.EXPBIAS) >> 4; | |||
| vu[F.EXPPOS_SHORT] = cast(ushort)((0x8000 & vu[F.EXPPOS_SHORT]) | 0x3FE0); | |||
| vu[F.EXPPOS_SHORT] = cast(ushort)((0x800F & vu[F.EXPPOS_SHORT]) | 0x3FE0); | |||
There was a problem hiding this comment.
I vaguely remember some discussion about this – but what was the issue here again?
There was a problem hiding this comment.
There was a problem hiding this comment.
That change should really be a stand alone commit rather than be mixed in to a larger, only barely related, set of changes.
|
Auto-merge toggled on |
|
Should be fine, but of course master is broken right now. -.- |
dnadlinger
added a commit
that referenced
this pull request
Jan 16, 2014
[ARM] Implement remaining std.math stuff
|
thanks |
|
The pleasure was all mine (although ideally, you would have included a link to that frexp discussion in the commit message). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ARM support in std.math. This pull request only contains the compiler-independent parts. Some inline-asm is necessary to make std.math work 100% but we won't upstream this code. The gdc implementation is here, for reference:
jpf91/GDC@017d7aa
Note: This is part of a set of changes which are required to get test suite & unit tests passing on ARM GDC. All necessary changes for GDC are here for reference:
https://github.com/jpf91/GDC/commits/arm-old
Once these pull requests are merged upstream I'll merge them into GDC as well.