[REG2.065a] Issue 12089 - std.utf.validate and inout(char[]) failts to compile

[9rnsr]

https://d.puremagic.com/issues/show_bug.cgi?id=12089

Unqual should support inout(const(T))

[monarchdodra]

What about bug https://d.puremagic.com/issues/show_bug.cgi?id=1308 ?

It would be nice to be able to have the initially suggested:

             static if (is(T U == const U)) alias Unqual!U Unqual;
        else static if (is(T U == immutable U)) alias Unqual!U Unqual;
        else static if (is(T U == inout U)) alias Unqual!U Unqual;
        else static if (is(T U == shared U)) alias Unqual!U Unqual;
        else alias T Unqual;

Other than that, LGTM

[9rnsr]

Sorry, I'm not sure that bug 1308 is really fixed. And, I think this change is better because it is low risk for the regression fix.

[monarchdodra]

Sorry, I'm not sure that bug 1308 is really fixed.

Yeah, I was just pointing out I think it's a shame to have to resort to making the full enumeration for this.

Related, doesn't ModifyTypePreservingSTC now have the exact same bug as Unqual?

And, I think this change is better because it is low risk for the regression fix.

Yup, no problem on my end. I'll merge once ModifyTypePreservingSTC is also addressed.

[9rnsr]

ModifyTypePreservingSTC now have the exact same bug as Unqual?

Good catch. I also fixed ModifyTypePreservingSTC.

[monarchdodra]

Auto-merge toggled on

[9rnsr]

Thanks!

[monarchdodra]

Style question: Would static if (is(T U == shared inout const U)) work, or are those parens necessary?

[9rnsr]

Of cause shared inout const U will work. Less parenthesis is better?

[monarchdodra]

Less parenthesis is better?

I guess, it looked like a weird "hybrid" style to me, so I was wondering if there was a reason for it. If there is no reason, I'd think it's better to use shared inout const U

[9rnsr]

OK, updated.

[braddr]

Pull updated, auto_merge toggled off

[monarchdodra]

Auto-merge toggled on

[9rnsr]

Thanks again!

[monarchdodra]

Good catch.

Hum... There's also the list of MutableOf, ConstOf, SharedInoutOf etc... that also need update. They are just package, but still, it is better to have code which is consistently correct.