Fix Issue 6998 - std.container.Array destroys class instances #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... class instances
|
LGTM. I think this should be safe to merge. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Apr 12, 2014
Fix Issue 6998 - std.container.Array destroys class instances
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As (re)discovered here:
http://forum.dlang.org/thread/bdzwpmehiazpicftbxko@forum.dlang.org
Also fixed some more cases where we only destroyed structs (what about static arrays?). Overall, the rule of thumb is
.destroyiffhasElaborateDestructor!T.https://issues.dlang.org/show_bug.cgi?id=6998