Improve value unformatting #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| deprecated alias ConvException ConvError; /// ditto | ||
|
|
||
| private void convError(S, T, string f = __FILE__, uint ln = __LINE__)(S source) | ||
| private void convError(S, T, string fn = __FILE__, uint ln = __LINE__)(S source) |
There was a problem hiding this comment.
ln should be size_t, since __LINE__ is size_t.
|
Apply reviewed fixes, and rebase. |
|
I'm merging this; Kenji-san, feel free to act on my comments in a future diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related pull request is #126.
Features:
Support static array and associative array parsing.
And escaped container elements are parsed correctly.
e.g.
assert(parse!(string[])(´["str1", "str2"]´) == ["str1", "str2"]);Support bool value and associative array unformatting.
And support range FormatSpec (e.g,
"%(...%)") .