Skip to content

Fix std.conv unittest for *nix OS #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2011
Merged

Fix std.conv unittest for *nix OS #212

merged 1 commit into from
Aug 24, 2011

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Aug 24, 2011

I bumped the bug 4539. In *nix OS this generates segfault.

jmdavis added a commit that referenced this pull request Aug 24, 2011
Fix std.conv unittest for *nix OS
@jmdavis jmdavis merged commit 977a0e7 into dlang:master Aug 24, 2011
@jmdavis
Copy link
Member

jmdavis commented Aug 24, 2011

Merged.

@braddr
Copy link
Member

braddr commented Aug 24, 2011

This needs to be 'unfixed' at some point.. it's not really a 'fix' at all, it's a work around. The original code should work just fine. So, please annotate it with a pointer to the bug so that there's a chance of finding it?

@jmdavis
Copy link
Member

jmdavis commented Aug 24, 2011

parse takes the string by ref. Why then would you expect it to work with a string literal?

@braddr
Copy link
Member

braddr commented Aug 24, 2011

I expect that parse doesn't change the input, so a string literal should be perfectly valid as an input parameter.

@jmdavis
Copy link
Member

jmdavis commented Aug 24, 2011

parse does change the input. It pops the characters that it parses from the front of the string. That's why it takes the string by ref.

@braddr
Copy link
Member

braddr commented Aug 24, 2011

On Tuesday, August 23, 2011 8:02:59 PM, jmdavis wrote:

parse does change the input. It pops the characters that it parses from the front of the string. That's why it takes the string by ref.

Ok.. clearly I'm not a user of that API yet, my apologies for the weak
review. I don't think 'consume' when I see 'parse'.

kuettler pushed a commit to kuettler/phobos that referenced this pull request Feb 6, 2018
Merge remote-tracking branch 'upstream/stable' into merge_stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants