Issue 11319 - std.range.zip is not nothrow. #2125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah that's what I get for only testing one module in isolation. Sigh.. |
ghost
closed this
|
Looks like a duplicate what I did in #2018. The bug report was duplicate though, so you couldn't have known. |
Well, oops. I think we need to let an app go through bugzilla and find and mark all duplicates, or at least show us similarly named bug reports so we can tick them as duplicates. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=11319
This is one way of implementing this, but there could be other ways. Essentially I've turned Exceptions into Errors.
I've also marked all zip unittests as
nothrow, although I've had to wrap somesortcalls which can still throw.This is a breaking change if user-code was already catching exceptions thrown from within
Zip. The only reason I could think this would happen is if the user called zip from within anothrowfunction and was forced to catch Exceptions. They wouldn't have to do that anymore.