Improved parallel foreach amap #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Buf and disallow using this overload with map because it's not safe. At some point it may be possible to special-case this overload of asyncBuf to work with map and parallel foreach, but until I decide what the best way to do that is and get around to implementing it, it should just be an error.
…ap. When working on std.parallel_algorithm, I discovered a way of doing these that was so much simpler, more elegant, more efficient and less bug-prone that I wanted to completely rip up the old implementation. Also, a few minor cleanups: 1. amap now can use any random access assignable range for output, not just an array. 2. map now statically disallows the buffer recycling overload of asyncBuf as input, since this never worked correctly. 3. Improved memory management for reduce to avoid the GC.
…hat I forgot about during all the refactoring.
|
Ping? |
…d was put in while debugging.
|
Forgot to mention, this pull request makes use of my changes to std.range in the unittests. Do not merge until after the std.range pull is merged. |
…d for asyncBuf and map.
…t went undetected for so long.
…easons that no longer apply. Changes to implementation details only.
|
Ok, I put some tests in for exception handling, and cleaned up a little cruft. |
|
This pull request now also contains an important bug fix (for Bug 6587) to allow Task to be used with const/immutable. I'd really like to get this into next release because it's a massive improvement to std.parallelism. |
…in, I have no idea when/how it got removed).
andralex
added a commit
that referenced
this pull request
Sep 4, 2011
Improved parallel foreach amap
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
Handle empty issue list more gently + avoid fetching the git remote directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive improvements to the implementation of parallel foreach and amap. When working on std.parallel_algorithm, I discovered a way of doing these that was so much simpler, more elegant, more efficient and less bug-prone that I wanted to completely rip up the old implementation. Also, a few minor cleanups: