Fix some issues of std.regex, enabling all ECMAv3 standard (?...) syntax. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debug(regex) - >debug(std_regex)
|
Done, oddly enough I can't get single char printed with %c (std.format.FormatError: std.format integral), so I used the universal %s instead. |
Also fixing the bug the size of an elephant (issue 5857).
|
Apparently it also fixes 5019 along the way. |
|
I made one more pass and added a few minor nits. |
|
OK, I think I've got the style: braces on it's own line, space after if, space after comma. |
|
I addressed all of the points. |
andralex
added a commit
that referenced
this pull request
May 1, 2011
Fix some issues of std.regex, enabling all ECMAv3 standard (?...) syntax.
redstar
added a commit
to redstar/phobos
that referenced
this pull request
Feb 7, 2016
AArch64 ieeeFlag fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues 5805, 1394 (but for std.regex not std.regexp), 5169, 5511, 5673.
Enables more proper unittesting.