reinsert doesPointTo in swap/move

[monarchdodra]

Basically reverts #1390 now that we have a more usable doesPointTo.

Pinging @DmitryOlshansky and @andralex.

I removed a unittest that was just kind of wrong (swapping with internal pointers), which I had introduced, but I'm not sure why...

[monarchdodra]

WTF are these failures?

[monarchdodra]

Hum... the version(assert) seems to be responsible for the error, but the code seems legit to me. Am I right in thinking this is a bug?

[dnadlinger]

@monarchdodra: It might be an issue with the linked Phobos library being built with different flags than the program. DMD likely expects that the missing symbols were emitted into libphobos already and skips them, but when the library is built, assertions are not enabled.

I think the proper fix for this is to ship two copies of Phobos, one used for release builds, and another with assertions in Phobos code enabled.

[monarchdodra]

@monarchdodra: It might be an issue with the linked Phobos library being built with different flags than the program. DMD likely expects that the missing symbols were emitted into libphobos already and skips them, but when the library is built, assertions are not enabled.

Hum... I figured as much, but we're dealing with templates here, so I'm surprised to see that this would happen. I'd expect the compiler to know if/if-not a symbol needs to be compiled and linked?

I think the proper fix for this is to ship two copies of Phobos, one used for release builds, and another with assertions in Phobos code enabled.

Arguably, that's a workaround?

[dnadlinger]

Arguably, that's a workaround?

@monarchdodra: Well, in the general case, one can not expect to be able to link against a library that has been compiled with completely different -version=… flags. Of course, one could still argue that -release is a special case, usability-wise…

[monarchdodra]

Alright, I removed the offending version(assert). This should be good to go now. @DmitryOlshansky ?

[CyberShadow]

This pull request may have introduced a regression:
http://forum.dlang.org/post/vldwvnuivsfwjozqiuup@forum.dlang.org