More ref return fixes in std.datetime now that the compiler allows them. #2227
Conversation
| @@ -6108,7 +6102,7 @@ public: | |||
|
|
|||
| { | |||
| auto st = SysTime(DateTime(0, 12, 31, 23, 59, 59), FracSec.from!"hnsecs"(9_999_999)); | |||
| st += dur!"hnsecs"(52) += dur!"seconds"(-907); | |||
| (st += dur!"hnsecs"(52)) += dur!"seconds"(-907); | |||
There was a problem hiding this comment.
This, code, did it silently change behavior, or is the change only a semantic/style? The "old" code used to be:
st += (dur!"hnsecs"(52) += dur!"seconds"(-907));Correct?
If I'm not mistaken the two bits do different things, but the end result is the same?
There was a problem hiding this comment.
They should have the same result, but different functions are involved. Without the parens, the += on the right adds the two Durations, whereas with the parens, it's being added to the SysTime which is returned by ref from SysTime's +=. And because the test is supposed to be testing that the ref return on SysTime's opAssign works correctly, I added the parens to make sure that both +=s call SysTime's opAssign instead of Duration's opAssign.
|
LGTM, just want your explanation WRT the parens. |
More ref return fixes in std.datetime now that the compiler allows them.
Compiler bugs previously returning by ref in several of std.datetime's functions. Fortunately, those bugs have been fixed (probably long since), so we can make those functions return by ref now.