Fix Issue 6644 - std.stdio write/writef(ln) are not @trusted #2233
Conversation
| @@ -2208,7 +2208,7 @@ $(D Range) that locks the file and allows fast writing to it. | |||
|
|
|||
| See $(LREF byChunk) for an example. | |||
| */ | |||
| auto lockingTextWriter() | |||
| auto lockingTextWriter() @trusted | |||
There was a problem hiding this comment.
This is kind of blunt, see #2225
|
ping |
|
This needs to be updated on top of #2225 - |
|
Will update this to work with #2225. |
rbanderton
changed the title
|
#2321 was merged, please update/rebase this, currently fails the auto-tester |
rbanderton
changed the title
|
Updated to be compatible with #2321. Tests pass locally and will fix any issues that come up in the auto-tester. |
|
Thanks. LGTM from me, need one more reviewer |
| } | ||
| } | ||
|
|
||
| @trusted void trustedTests() |
There was a problem hiding this comment.
System is the same as trusted, as far as the allowed operations are concerned, so just get rid of this section.
|
@rbanderton: Thanks a lot, looks good to me now! One last request: Could you please squash the commits together into one? |
|
Of course. Rebased to master/squashed commits. |
|
LGTM. This will make |
|
Auto-merge toggled on |
Fix Issue 6644 - std.stdio write/writef(ln) are not @trusted
https://issues.dlang.org/show_bug.cgi?id=6644
More discussion here: http://stackoverflow.com/questions/19101305/how-can-i-do-i-o-in-safe-functions-in-d
Changes I have made to get
writeand family callable from@safecode:LockingTextWriterand factory function@trusted- I didn't see anything inherently unsafe about the way it manages the lock. I'm certainly open to correction, though.stdoutglobal variable's usage in aprivate @trustedproperty that is used bywriteand friends. If this is not done they always infer to@systemdue to accessing a global variable. I'm not 100% sure this is safe to to, but with the property being private all external use of the global will still be@system.This is much like #2230 except it does not use free functions - after more testing I found they worked fine as member functions. This is a separate pull request because I'm terrible at git :/