Issue 13015 - std.json.JSONValue's toString is now const #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return toJSON(&this); | ||
| } | ||
|
|
||
| /// Implicitly calls $(D toJSON) on this JSONValue, like $(D toString), but | ||
| /// also passes $(I true) as $(I pretty) argument. | ||
| string toPrettyString() | ||
| string toPrettyString() const |
There was a problem hiding this comment.
Even though it calls the same toJSON function ATM it would be nice to at least call it in the unittest below.
|
Otherwise LGTM |
|
@DmitryOlshansky - Added test. |
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Jul 5, 2014
Issue 13015 - std.json.JSONValue's toString is now const
9rnsr
pushed a commit
to 9rnsr/phobos
that referenced
this pull request
Jul 7, 2014
Issue 13015 - std.json.JSONValue's toString is now const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13015