fix Issue 12853 - std.encoding EncodingSchemeUtf16Native and EncodingSch... #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SchemeUtf32Native decode() and SafeDecode() wrong stripping length
| @@ -2787,7 +2787,7 @@ class EncodingSchemeUtf16Native : EncodingScheme | |||
| { | |||
| auto t = cast(const(wchar)[]) s; | |||
| dchar c = std.encoding.decode(t); | |||
| s = s[$-t.length..$]; | |||
| s = s[$-t.length*wchar.sizeof..$]; | |||
There was a problem hiding this comment.
space around operators please
s = s[$ - t.length * wchar.sizeof .. $];(throughout)
|
Fine pending nits. |
|
Not fine without a unit test. There's one in the bug report and it (or something like it) should be included in the pull. |
…SchemeUtf32Native decode() and SafeDecode() wrong stripping length
|
LGTM |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Jul 17, 2014
fix Issue 12853 - std.encoding EncodingSchemeUtf16Native and EncodingSch...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...emeUtf32Native decode() and SafeDecode() wrong stripping length
Submitting pull as implemented by Ketmar Dark in https://issues.dlang.org/show_bug.cgi?id=12853