Issue 13232 - avoid expensive template instantiations on module import #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide std.uni.TrieBuilder instantiations behind functions
|
LGTM. But I'll defer to Dmitry to have the final say on whether this should merge. |
|
@DmitryOlshansky can you have a look at this? |
|
I recall being not sure if these aliases would make it compile the functions eagerly. Turns out they do. LGTM, thanks @MartinNowak . |
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Aug 1, 2014
Issue 13232 - avoid expensive template instantiations on module import
It really shouldn't be eager. I opened an enhancement request to improve the compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 13232