Fix issue #13354 - Use a generic Variant for passing opIndex/opIndexAssign arguments.

[s-ludwig]

Also improves the error message when an incompatible index or value type is used by printing the actual type ID instead of void[] in the thrown exception.

Note that this removes the allowed!T checks that have a comment on them, stating that they fix some kind of unspecified bug. However, removing that restriction is the reason for this pull request in the first place and all tests still pass as they should.

https://issues.dlang.org/show_bug.cgi?id=13354
https://issues.dlang.org/show_bug.cgi?id=7449

[mihails-strasuns]

Changes make sense. There is an old duplicate issue about it which indicates that bug report from the comment must have been the case quite some time ago. I think it is ok to ignore it for now.

[quickfur]

ping
Are we going ahead with this?

[quickfur]

P.S. please put the URL of the bug in the PR description so that the autotester can update the bug once this merges.

[mihails-strasuns]

I'd expect it to look at commit titles / messages, not PR titles.

[mihails-strasuns]

@quickfur I assume your comment can be considered "LGTM", merging ;)

[mihails-strasuns]

Auto-merge toggled on

[yebblies]

@Dicebot The PR titles end up in the merge commit message.

[mihails-strasuns]

But merge commit includes also all original PR commits as-is with all their messages.

[braddr]

@quickfur For what it's worth, it's not the auto-tester updating bugzilla. Github does that itself.

[quickfur]

Oh I see. Didn't know that. So github knows about bugzilla URLs enough to auto-update them? That's neat... and kinda scary at the same time. :P

[dnadlinger]

@quickfur: It's not the URLs in the description – you manually need to configure a hook in the project admin panel (which parses the commit messages).

[quickfur]

Ah I see.