Remove goto into catch block.

[ibuclaw]

Replace goto with throw in std.format function.

This code is just asking for trouble.... :o)

[9rnsr]

Thrown UtfException is never used, so how about you changing like follows?

-        catch (UtfException e)
+        catch (UtfException)
         {
 InvalidSeq:

[9rnsr]

Or, we can extract "invalid sequence handling" out of catch statement.

  bool invalidSeq = false;
  try {
    ... // may throw UtfException
    if (c == 0xFFFE || c == 0xFFFF)
    { invalidSeq = true; goto LinvalidSeq; }
    ...
  } catch (UtfException) {
    invalidSeq = true;  // Come here if only exception was really thrown
  }

LinvalidSeq:
  if (invalidSeq)
  { /* error handling */ }

[ibuclaw]

Andrei - it's a comment in diguise. :~)

9rnsr - sure, that way would be great too (give me a couple of hours to prepare / commit it)