Revert pull request #2537 to fix git-head regression issue 13498 #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR blocks the compiler fix: dlang/dmd#4004 |
|
You must have meant to revert 2537 instead, right? |
9rnsr
changed the title
|
@Dicebot Ouch, I fixed summary and commit log. |
|
It still contains unrelated revertion of changes to |
|
LGTM, sorry for not noticing the bug. |
|
Gaa! Sorry the unnecessary change in std.format had come from my local change. I removed it. |
quickfur
pushed a commit
that referenced
this pull request
Sep 20, 2014
Revert pull request #2537 to fix git-head regression issue 13498
|
Thanks for quick merging! |
|
No problem, I'll resubmit this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13498
This reverts commit 875f2fe, reversing
changes made to f5c7e97.
The changed absolutePath code essentially cannot work because the buildPath() result is not implicitly convertible to inout(char)[], but it was accidentally accepted by the regression 13498.