Skip to content

takeOne doesn't work with non-forward ranges #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Dec 31, 2014
Merged

takeOne doesn't work with non-forward ranges #2808

2 commits merged into from
Dec 31, 2014

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Dec 24, 2014

Fixes a bug reported by bioinfornatics on forum.

range even the basic io as ByLine which implement range can't
work with std.range.takeOne as is not an Input Range. While a
basic function such as takeOne do not really need to use save
method to work a forward range is enough.

@ghost
Copy link

ghost commented Dec 31, 2014

Auto-merge toggled on

@ghost
Copy link

ghost commented Dec 31, 2014

Thanks, although there should be a bug report on bugzilla too! :)

ghost pushed a commit that referenced this pull request Dec 31, 2014
@AndrejMitrovic
Merge pull request #2808 from sinkuu/takeone
3b182e4 
takeOne doesn't work with non-forward ranges
@ghost ghost merged commit 3b182e4 into dlang:master Dec 31, 2014
@sinkuu
Copy link
Contributor Author

sinkuu commented Jan 1, 2015

Thanks!

although there should be a bug report on bugzilla too! :)

Done: https://issues.dlang.org/show_bug.cgi?id=13922

@sinkuu sinkuu deleted the takeone branch January 1, 2015 13:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sinkuu