Added opEquals to InternetAddress #2839
Conversation
| * Examples: | ||
| * -------------- | ||
| * InternetAddress addr1,addr2; | ||
| * if (addr1 == addr2) { } |
There was a problem hiding this comment.
Uhm.. won't this example segfault due to a null this? I forgot whether this was ever fixed (or ever will be).
There was a problem hiding this comment.
I tested it and it seems to work. http://dlang.org/operatoroverloading.html
If a and b are both class objects, then the expression is rewritten as:
.object.opEquals(a, b)
and that function is implemented as:bool opEquals(Object a, Object b) { if (a is b) return true; if (a is null || b is null) return false; // NULL HANDLED HERE if (typeid(a) == typeid(b)) return a.opEquals(b); return a.opEquals(b) && b.opEquals(a); }
|
Auto-merge toggled on |
Added opEquals to InternetAddress
ghost
merged commit
|
Thanks, looks good. |
| override bool opEquals(Object o) const | ||
| { | ||
| auto other = cast(InternetAddress)o; | ||
| return other && this.sin.sin_addr.s_addr == other.sin.sin_addr.s_addr && |
There was a problem hiding this comment.
Is testing other for null really necessary?
There was a problem hiding this comment.
other will be null if o wasn't an InternetAddress.
There was a problem hiding this comment.
That's a good thing to discuss. It depends on how opEquals is supposed to be used. If it's valid to pass other non-InternetAddress objects then it is necessary. If not, then we could use a contract to validate that o is of type InternetAddress. However, I plan on submitting an enhancement request to change the '==' operator to use a typed opEquals instead of the generic one, which would mean we wouldn't need to cast the Object parameter cause we could just use an InternetAddress directly.
I'm not sure why the Address classes do not have opEquals implemented. I've added it to the InternetAddress class. If this get's "approved" then I can add the other opEquals methods to the other Address classes.