Skip to content

Use presence of __va_argsave to determine if __va_argsave hack is needed #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2015
Merged

Use presence of __va_argsave to determine if __va_argsave hack is needed #2902

merged 1 commit into from
Jan 24, 2015

Conversation

yebblies
Copy link
Contributor

This replaces the current awkward version condition, and makes the code future-proof with regards to the hopefully imminent removal of __va_argsave.

@yebblies
Copy link
Contributor Author

This is broken for now because of a rather nasty win64 varargs bug. That explains why the code originally used _argptr instead of va_start.

@yebblies yebblies mentioned this pull request Jan 24, 2015
Merged
@andralex
Copy link
Member

thanks

andralex added a commit that referenced this pull request Jan 24, 2015
@andralex
Merge pull request #2902 from yebblies/typeofva_argsave
f07a77d 
Use presence of __va_argsave to determine if __va_argsave hack is needed
@andralex andralex merged commit f07a77d into dlang:master Jan 24, 2015
@9rnsr
Copy link
Contributor

9rnsr commented Jan 24, 2015

@andralex Please use auto-merge always. This change breaks current master in Win64.

9rnsr added a commit to 9rnsr/phobos that referenced this pull request Jan 24, 2015
@9rnsr
Revert "Merge pull request dlang#2902 from yebblies/typeofva_argsave"
5417836 
This reverts commit f07a77d, reversing
changes made to 4bd9494.

It's breaking std.outbuffer unittest in Win64 platform.
9rnsr added a commit that referenced this pull request Jan 24, 2015
@9rnsr
Merge pull request #2905 from 9rnsr/revert_pull2902
80f463a 
Revert "Merge pull request #2902 from yebblies/typeofva_argsave"
@yebblies
Copy link
Contributor Author

I do appreciate the review but please use auto-merge. You can easily get to the pull request's auto-tester page by clicking the 'Details' link on the right next to the results.

@yebblies yebblies deleted the typeofva_argsave branch January 25, 2015 03:02
This was referenced Jan 25, 2015
Merged
Merged
andralex pushed a commit to andralex/phobos that referenced this pull request Feb 1, 2015
@9rnsr @andralex
Revert "Merge pull request dlang#2902 from yebblies/typeofva_argsave"
4b9f5e5 
This reverts commit f07a77d, reversing
changes made to 4bd9494.

It's breaking std.outbuffer unittest in Win64 platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yebblies @andralex @9rnsr