std.math: №4, workaround for intrinsics #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9il
added a commit
to 9il/dmd
that referenced
this pull request
Feb 20, 2015
dlang/phobos#3014 depends on this PR.
Merged
|
LGTM |
redstar
pushed a commit
to ldc-developers/dmd-testsuite
that referenced
this pull request
Mar 23, 2015
dlang/phobos#3014 depends on this PR.
|
@9il do you have anything to add here? |
|
No, I have not. Other stuff like |
|
Auto-merge toggled on |
|
Thanks! |
|
thank you |
burner
added a commit
that referenced
this pull request
Apr 8, 2015
std.math: №4, workaround for intrinsics
| double rndtol(double x) @safe pure nothrow @nogc { return rndtol(cast(real)x); } | ||
| //FIXME | ||
| ///ditto | ||
| float rndtol(float x) @safe pure nothrow @nogc { return rndtol(cast(real)x); } |
There was a problem hiding this comment.
??? Why did this get merged? The return type is obviously wrong!
There was a problem hiding this comment.
O_o. I will create new PR right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dlang/dmd#4425