fix Issue 14300 - DList casting to base type is broken #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All insert methods should take `auto ref T t` instead of `Stuff t`, because the latter is an unnecessary temporary if `Stuff` isn't `T`. - Small, copyable, register sized Ts should always be passed by-value instead of auto ref.
|
I didn't threw out |
WalterBright
added a commit
that referenced
this pull request
Mar 20, 2015
fix Issue 14300 - DList casting to base type is broken
WalterBright
added a commit
that referenced
this pull request
Mar 20, 2015
fix Issue 14300 - DList casting to base type is broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto ref T tinstead of
Stuff t, because the latter isan unnecessary temporary if
Stuffisn'tT.passed by-value instead of auto ref.
Issue 14300 – [2.067-rc1] DList casting to base type is broken