Skip to content

Conversation

aka-demik
Copy link
Contributor

Continue of phobos#3138. Issue 7648 was fixed in DMC runtime.
This PR removes Issue 7648 from bugs list in docs. And add Non-ASCII characters in filename for unittests.

@schveiguy
Copy link
Member

I think the auto-tester needs to have updated snn.lib. @braddr?

@aka-demik
Copy link
Contributor Author

I think the auto-tester needs to have updated snn.lib. @braddr?

Any news?
What we need to correct, to add a new snn.lib in setup?

@aka-demik
Copy link
Contributor Author

ping @schveiguy @braddr .
DConf ended. Maybe we will proceed?

@aka-demik
Copy link
Contributor Author

Ping @schveiguy
Maybe we will proceed?

@schveiguy
Copy link
Member

@aka-demik I can't fix this. snn.lib is not included in any source packages on github. I have no idea how the package is assembled. Someone with better knowledge of how the build system works will have to do it.

@aka-demik
Copy link
Contributor Author

As I see it, the new version SNN.lib gets into setup automatically. But I can not find how to d-tester gets SNN.lib.
Maybe, after the release of 2.068 everything will be fine?
@braddr

@quickfur quickfur changed the title Cleanup for Issue 7648. Cleanup for Issue 7648: std.stdio expects file names to be encoded in CP_ACP on Windows instead of UTF-8 Jul 21, 2015
@quickfur
Copy link
Member

Updated PR title to be more descriptive.

@quickfur
Copy link
Member

Does anyone know how to update snn.lib on the autotester? This bugfix has been sitting here idle for a long time. We need to get moving on it.

@MartinNowak
Copy link
Member

As I see it, the new version SNN.lib gets into setup automatically.

Correct, the build script will get the latest snn.lib from the ftp, as for the auto-tester you'll have to write a mail to @braddr.

@aka-demik
Copy link
Contributor Author

you'll have to write a mail to braddr.

Done.

@aka-demik
Copy link
Contributor Author

Thanks to braddr, it's green now.

@schveiguy
Copy link
Member

It's failing in Mac 32-bit. This makes no sense, and I have no idea what this means:

Testing merge_true
5c5
<       2|    dmd_coverSetMerge(true);
---
>       3|    dmd_coverSetMerge(true);
make[2]: *** [generated/osx/release/32/merge_true.done] Error 1
make[1]: *** [test/coverage/.run] Error 2
make: *** [unittest-release] Error 2
make: *** Waiting for unfinished jobs....
5c5
<       2|    dmd_coverSetMerge(true);
---
>       4|    dmd_coverSetMerge(true);
make[2]: *** [generated/osx/debug/32/merge_true.done] Error 1
make[1]: *** [test/coverage/.run] Error 2
make: *** [unittest-debug] Error 2

@aka-demik
Copy link
Contributor Author

Hmm...
Strange. Maybe I made the wrong rebase. But the rest of build hosts have worked fine.
I can reopen this PR again if this is merge problem.

@schveiguy
Copy link
Member

I don't think the name of the function has to do with git merge (as that is done at the beginning before building). I have absolutely no clue what it means though.

@aka-demik
Copy link
Contributor Author

I don't think the name of the function has to do with git merge

Yep. This is core.runtime.dmd_coverSetMerge.

And it floats.

1702162     Darwin_64_32    2015-08-20 07:30:06     00:18:11    P   1   3a025da7c69f66b28c0eed53aa9ea1ccced01623    D-Autotester.local
...
1701891     Darwin_64_32    2015-08-20 02:31:28     00:06:01    F   1   3a025da7c69f66b28c0eed53aa9ea1ccced01623    macair
...
1701485     Darwin_64_32    2015-08-19 19:22:20     00:18:19    P   1   3a025da7c69f66b28c0eed53aa9ea1ccced01623    D-Autotester.local

Fails on macair, passed on D-Autotester.local.

It may be green,
or may be red,
or Autotester may be dead?  

😔

@schveiguy
Copy link
Member

@schveiguy
Copy link
Member

I think we can merge this now.

@schveiguy
Copy link
Member

Auto-merge toggled on

schveiguy added a commit that referenced this pull request Aug 21, 2015
Cleanup for Issue 7648: std.stdio expects file names to be encoded in CP_ACP on Windows instead of UTF-8
@schveiguy schveiguy merged commit 6df5d55 into dlang:master Aug 21, 2015
@aka-demik aka-demik deleted the Issue-7648 branch August 24, 2015 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants