Skip to content

Add attributes to methods in std.json. #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2015
Merged

Add attributes to methods in std.json. #3348

merged 1 commit into from
May 30, 2015

Conversation

jcrapuchettes
Copy link
Contributor

Add pure, nothrow, @safe, and @nogc where possible for methods, but not for the templated functions and methods.

@burner
Copy link
Member

burner commented May 30, 2015

LGTM

@schveiguy
Copy link
Member

Auto-merge toggled on

schveiguy added a commit that referenced this pull request May 30, 2015
@schveiguy
Merge pull request #3348 from economicmodeling/add_attributes_to_json
d8e2ad4 
Add attributes to methods in std.json.
@schveiguy schveiguy merged commit d8e2ad4 into dlang:master May 30, 2015
@CyberShadow
Copy link
Member

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=15423

@jcrapuchettes jcrapuchettes deleted the add_attributes_to_json branch December 9, 2015 19:16
@JackStouffer JackStouffer mentioned this pull request Dec 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcrapuchettes @burner @schveiguy @CyberShadow