workaround Issue 14718 - float parsing depends on platform strtold #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- comment out the affected unittests for now
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Jun 21, 2015
workaround Issue 14718 - float parsing depends on platform strtold
|
Thx! |
|
No no no, the test should be elided ONLY for the platform it fails on, not all platforms! |
Of course it would be the best way, but how distinguish |
|
At least it should be versioned out for Linux systems, not all. |
|
It's a problem during lexing so we can't version it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 14718 – float parsing depends on libc strtold precision