2.068 renames #3439
Closed
2.068 renames #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New names: asLowerCase, asUpperCase, asCapitalized Discussions: http://forum.dlang.org/post/fafybgnltpkfwpugyqvm@forum.dlang.org http://forum.dlang.org/post/qdtisgsafprcczbjfizz@forum.dlang.org
| assert (setExt("file.ext"w.byWchar, ".").array == "file."w); | ||
| assert (withExtension("file".byChar, "ext").array == "file.ext"); | ||
| assert (withExtension("file"w.byWchar, ".ext"w).array == "file.ext"w); | ||
| assert (withExtension("file.ext"w.byWchar, ".").array == "file."w); |
There was a problem hiding this comment.
This example (documented unittest) would look much better if UFCS was used, should I update it?
CyberShadow
force-pushed
the
renames-2.068
branch
from
19721fc to
ab40bbd
Compare
|
@MartinNowak ping |
1 similar comment
|
@MartinNowak ping |
|
So, do I recreate this pull and target the stable branch? |
To increase its chances of getting pulled, I say "yes". |
|
@CyberShadow yes, likely it needs to target both branches. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion:
http://forum.dlang.org/post/rvaguhviuldknnqktkbq@forum.dlang.org
For now this is a draft.I'll be updating this up to RC1 following feedback.@MartinNowak What's the ETA to RC1?