fix Issue 14751 - std.array.array doesn't work with ranges of immutable classes #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| ++i; | ||
| result.reserve(length); | ||
|
|
||
| foreach (e; r) |
There was a problem hiding this comment.
Ehm, append still going to check capacity on each element. IIRC it's not that fast since it does a round-trip via druntime's extern(C) API. Much as unfortunate as it is I don't believe the strange use case of immutable classes outweights the performance loss.
I say that immutable class is strange for the reason that:
- due to no being able to express syntactically tail-const object references is of limited use (very limited at that)
- OOP is typically about incapsulating mutable state inside of objects.
- it contains mutable monitor field anyway
|
ping Any response based on Dmitry's feedback? |
|
Immutable and classes have never worked well together, but we may as well support it if we can. |
|
I need immutability to safely pass class objects (I also need polymorphism) between threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.dlang.org/show_bug.cgi?id=14751