-
-
Notifications
You must be signed in to change notification settings - Fork 742
Add Specializations for SortedRange #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9e13329
Improve comment
nordlow 990f5d9
First try at isSortedRange
nordlow a435e4a
First working version of isSortedRange
nordlow a0c62d9
Add alias fun in unittest
nordlow 79ae662
Move isSortedRange to primitives
nordlow 95e8d55
Add failing use of isSortedRange in sort()
nordlow 513c680
Make isSortedRange more robust
nordlow ac89671
Add comment
nordlow 07063e0
Add specialization of isSorted
nordlow 0670174
Remove import std.range.primitives: isSortedRange;
nordlow 144c686
Support minPos
nordlow cb2c335
Bugfix
nordlow 54ee64a
Add minElement and maxElement
nordlow 9f3e555
Move empty check in minPos to else clauses
nordlow 88ac1b0
Add space
nordlow 88f586d
Only calculate TemplateArgsOf!T once
nordlow dbcf473
Use __traits(isSame, )
nordlow d6d9c1f
Fix bug in isSortedRange
nordlow 681d476
Robuster isSortedRange
nordlow f6b9df7
More general standardizePredicate
nordlow 2812b99
Better naming comments for standardizePredicate*
nordlow b7bf452
Change return type of minPos from auto to Range
nordlow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need these? "Compliance with C++ STL" doesn't seem like a good argument. I recommend moving these to a different PR where they can be evaluated separately.