update curl.d documentation #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples assign the results of curl functions to a string. But that doesn't work on dmd 2.068 running on arch, so I suggest we update them. Please double-check my changes as I made them very quickly as limited time.
MartinNowak
added a commit
that referenced
this pull request
Aug 19, 2015
update curl.d documentation
|
How about turning these examples to documented unit test blocks? |
|
Someone else with standing on forum said you don't want web access in unit test. You could of course launch a local server, but that may be overkill. Thing is it seems one of the fiddler and more brittle modules. In any case, I don't have time to add those myself at the moment, I am afraid, although seems a good idea to me. Sent from my iPad
|
|
That's a good point, didn't think of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples assign the results of curl functions to a string. But that doesn't work (at least on on dmd 2.068 running on arch), so I suggest we update them. Please double-check my changes as I made them very quickly as limited time.